perf(metrics): send all seven queries in one D1 batch

Avoid seven sequential network round trips and read totals, breakdowns and recent failures in one consistent transaction. Reuse the failed-send statement and row mapping while retaining group scoping.
This commit is contained in:
翅膀 committed 2026-10-17 17:08:31 +08:00
1 parent 244b5c6ffe
commit 6cdcedde92
4 files changed
+86 -56

No files matched your search

+54 -42
View File
@@ -1,5 +1,5 @@
import { log } from "../lib/log";
import { getFailedSendLog, type SendRecord } from "../lib/send-log";
import { failedSendLogStatement, toRecord, type LogRow, type SendRecord } from "../lib/send-log";
export interface DeliveryMetrics {
total: number;
@@ -64,65 +64,77 @@ export async function getDeliveryMetrics(
groupId ? stmt.bind(groupId) : stmt;
try {
const totals = await bindGroup(
db.prepare(`SELECT COUNT(*) AS total, COALESCE(SUM(ok), 0) AS ok FROM send_logs${where}`),
).all<TotalsRow>();
const total = Number(totals.results[0]?.total) || 0;
const ok = Number(totals.results[0]?.ok) || 0;
// One round trip for all seven queries (each D1 call is a network hop), and
// a batch runs as one transaction, so the totals and breakdowns agree.
const results = await db.batch([
bindGroup(
db.prepare(`SELECT COUNT(*) AS total, COALESCE(SUM(ok), 0) AS ok FROM send_logs${where}`),
),
bindGroup(
db.prepare(
`SELECT platform AS key, COUNT(*) AS total, COALESCE(SUM(ok), 0) AS ok
FROM send_logs${where} GROUP BY platform`,
),
),
bindGroup(
db.prepare(
`SELECT event AS key, COUNT(*) AS total, COALESCE(SUM(ok), 0) AS ok
FROM send_logs${where} GROUP BY event`,
),
),
bindGroup(
db.prepare(
`SELECT status, COUNT(*) AS count FROM send_logs
WHERE status IS NOT NULL${and} GROUP BY status`,
),
),
bindGroup(
db.prepare(
`SELECT AVG(duration_ms) AS avg FROM send_logs WHERE duration_ms IS NOT NULL${and}`,
),
),
bindGroup(
db.prepare(
`SELECT COALESCE(SUM(attempts), 0) AS total, AVG(attempts) AS avg
FROM send_logs WHERE attempts IS NOT NULL${and}`,
),
),
failedSendLogStatement(db, 20, groupId),
]);
const rows = <T>(i: number): T[] => (results[i]?.results ?? []) as T[];
const totals = rows<TotalsRow>(0);
const byPlatform = rows<BreakdownRow>(1);
const byEvent = rows<BreakdownRow>(2);
const byStatus = rows<StatusRow>(3);
const duration = rows<AvgRow>(4);
const attempts = rows<AttemptsRow>(5);
const recentFailures = rows<LogRow>(6).map(toRecord);
const byPlatform = await bindGroup(
db.prepare(
`SELECT platform AS key, COUNT(*) AS total, COALESCE(SUM(ok), 0) AS ok
FROM send_logs${where} GROUP BY platform`,
),
).all<BreakdownRow>();
const byEvent = await bindGroup(
db.prepare(
`SELECT event AS key, COUNT(*) AS total, COALESCE(SUM(ok), 0) AS ok
FROM send_logs${where} GROUP BY event`,
),
).all<BreakdownRow>();
const byStatus = await bindGroup(
db.prepare(
`SELECT status, COUNT(*) AS count FROM send_logs
WHERE status IS NOT NULL${and} GROUP BY status`,
),
).all<StatusRow>();
const duration = await bindGroup(
db.prepare(
`SELECT AVG(duration_ms) AS avg FROM send_logs WHERE duration_ms IS NOT NULL${and}`,
),
).all<AvgRow>();
const attempts = await bindGroup(
db.prepare(
`SELECT COALESCE(SUM(attempts), 0) AS total, AVG(attempts) AS avg
FROM send_logs WHERE attempts IS NOT NULL${and}`,
),
).all<AttemptsRow>();
const recentFailures = await getFailedSendLog(db, 20, groupId);
const total = Number(totals[0]?.total) || 0;
const ok = Number(totals[0]?.ok) || 0;
return {
total,
ok,
failed: total - ok,
failureRate: total > 0 ? (total - ok) / total : 0,
byPlatform: byPlatform.results.map((r) => {
byPlatform: byPlatform.map((r) => {
const t = Number(r.total) || 0;
const o = Number(r.ok) || 0;
return { platform: r.key ?? "unknown", total: t, ok: o, failed: t - o };
}),
byEvent: byEvent.results.map((r) => {
byEvent: byEvent.map((r) => {
const t = Number(r.total) || 0;
const o = Number(r.ok) || 0;
return { event: r.key ?? "unknown", total: t, ok: o, failed: t - o };
}),
byStatus: byStatus.results.map((r) => ({
byStatus: byStatus.map((r) => ({
status: String(r.status),
count: Number(r.count) || 0,
})),
avgDurationMs: Number(duration.results[0]?.avg) || 0,
totalAttempts: Number(attempts.results[0]?.total) || 0,
avgAttempts: Number(attempts.results[0]?.avg) || 0,
avgDurationMs: Number(duration[0]?.avg) || 0,
totalAttempts: Number(attempts[0]?.total) || 0,
avgAttempts: Number(attempts[0]?.avg) || 0,
recentFailures,
};
} catch (err) {