From 966403bdc18ebcb4e2c45f7ede734dedc367e07e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=BF=85=E8=86=80?= Date: Fri, 23 Oct 2026 23:22:25 +0800 Subject: [PATCH] fix(discord): encode channel path segments Stored channel and message ids are path segments, not URL paths. Encode them so aliases cannot address another Discord resource. --- server/lib/drivers/discord/rest.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/server/lib/drivers/discord/rest.ts b/server/lib/drivers/discord/rest.ts index e9c4aff..a31e58a 100644 --- a/server/lib/drivers/discord/rest.ts +++ b/server/lib/drivers/discord/rest.ts @@ -107,9 +107,9 @@ export async function sendMessage( message: unknown, threadId?: string, ): Promise { - const url = threadId - ? `${DISCORD_API}/channels/${threadId}/messages` - : `${DISCORD_API}/channels/${channelId}/messages`; + // Ids are path segments: encoded, so no stored value can address another + // resource (`x/../123` is never the channel `123`). + const url = `${DISCORD_API}/channels/${encodeURIComponent(threadId || channelId)}/messages`; return request(url, "POST", token, message, channelId); } @@ -120,7 +120,7 @@ export async function editMessage( message: unknown, threadId?: string, ): Promise { - const base = threadId ?? channelId; - const url = `${DISCORD_API}/channels/${base}/messages/${messageId}`; + const base = encodeURIComponent(threadId || channelId); + const url = `${DISCORD_API}/channels/${base}/messages/${encodeURIComponent(messageId)}`; return request(url, "PATCH", token, message, channelId); }