From f14f8f317fea7ed5c366f2cab77d98e09a1998f3 Mon Sep 17 00:00:00 2001 From: RhenCloud Date: Sat, 24 Oct 2026 16:05:29 +0800 Subject: [PATCH] fix(security): fully escape forge HTML --- server/lib/drivers/feishu/render.ts | 5 ++++- server/lib/formatters/helpers.ts | 6 +++++- tests/lifecycle-safety.test.ts | 13 +++++++++++++ 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/server/lib/drivers/feishu/render.ts b/server/lib/drivers/feishu/render.ts index f4ad98f..3d5adf7 100644 --- a/server/lib/drivers/feishu/render.ts +++ b/server/lib/drivers/feishu/render.ts @@ -33,7 +33,10 @@ function colorToTemplate(color?: number): FeishuTemplate { * up (a zero-width space after `<`) and shows as text. */ function noMentions(content: string): string { - return content.replace(/<(\/?)(at)\b/gi, "<\u200b$1$2"); + // Escape every angle bracket, not only `/g, ">"); } function mdText(content: string): { tag: "lark_md"; content: string } { diff --git a/server/lib/formatters/helpers.ts b/server/lib/formatters/helpers.ts index 159a4ea..1d754c7 100644 --- a/server/lib/formatters/helpers.ts +++ b/server/lib/formatters/helpers.ts @@ -207,7 +207,11 @@ function stripHtml(input: string): string { .replace(/<\/(p|div|tr|h[1-6]|ul|ol|table|blockquote)>/gi, "\n") .replace(/<\/t[dh]>/gi, " ") .replace(/]*>/gi, "\n• ") - .replace(/<[^<>]+>/g, ""); + // A prefix such as `` is + // absent or is supplied later by a renderer. Remove the opening bracket + // itself after known HTML has been converted to text. + .replace(/<[^<>]+>/g, "") + .replace(/ { expect(/<\/?at\b/i.test(card)).toBe(false); }); + it("does not leave HTML tag prefixes in Feishu markdown", async () => { + const { renderNeutralMessage } = await import("../server/lib/drivers/feishu/render"); + const card = JSON.stringify( + renderNeutralMessage({ + title: "repo: ", + description: "