Commit Graph
228 Commits
Author SHA1 Message Date
翅膀 a98ff778a2 perf(d1): index pruning and failed send queries
Pruning and failure views should not scan all historical rows.
Index the high-value access paths without adding a write-heavy
index for infrequent delivery-detail lookups.
2026-10-23 23:22:14 +08:00
翅膀 b71cd7b6bb fix(logs): scope queries before limiting results
Filter authorized groups in SQL before LIMIT and aggregate only
visible rows. Preserve current group attribution for late writes,
surface read failures and combine related totals in one scan.
2026-10-23 23:22:10 +08:00
翅膀 76380ff1c0 fix(check): isolate updates by check suite
Same-named checks from different suites must not edit one message.
Include the suite or app identity and retain the former key for
controlled adoption of existing tracked messages.
2026-10-23 23:22:04 +08:00
翅膀 a95feefaf8 fix(formatter): hide actions on other forges
Action buttons call the GitHub API as the linked user.
Hide them for other forges to avoid operating on a same-named
GitHub repository.
2026-10-23 23:22:00 +08:00
翅膀 2e672034d0 fix(formatter): read security severity levels
The scanner severity is not the security severity of an alert.
Prefer the security level so critical and high alerts get the right
label and color.
2026-10-23 23:21:59 +08:00
翅膀 61be34da4f fix(formatter): render deployment state values
The deployment status object stringifies as [object Object].
Render its actual state in the status field.
2026-10-23 23:21:58 +08:00
翅膀 2911519f18 fix(gitea): link push authors to their forge
A Gitea author is not the same-named GitHub account.
Build author profile links from the originating forge.
2026-10-23 23:21:54 +08:00
翅膀 aca870374f fix(formatter): strip only leading ref prefixes
A short branch or tag may itself contain refs/heads or refs/tags.
Strip one leading full-ref prefix at the caller and keep short names
unchanged when generating labels and links.
2026-10-23 23:21:50 +08:00
翅膀 e44fc60c55 fix(formatter): preserve bounded markdown text
Code spans, fences, indentation and autolinks are Markdown content,
not HTML tags to strip. Preserve them while bounding cleanup input
and reusing results across routes for the same event.
2026-10-23 23:21:46 +08:00
翅膀 99d239ff4f fix(formatter): preserve invalid code points
Out-of-range numeric entities can throw while formatting a delivery.
Keep invalid code points verbatim instead of aborting the message.
2026-10-23 23:21:43 +08:00
翅膀 1b3f353153 fix(github): restrict enrichment request urls
Webhook-provided URLs must never receive an installation token on
another host. Restrict enrichment to GitHub repository API paths,
reject redirects and bound optional requests.
2026-10-23 23:21:39 +08:00
翅膀 d5e86bb4d9 fix(github): bound and reuse app token fetches
Repeated token exchanges waste requests and JWT work for every event.
Reuse valid installation tokens, share refreshes and back off briefly
after failures while keeping every shared wait bounded.
2026-10-23 23:21:38 +08:00
翅膀 2d87367b48 i18n(bot): explain command and account failures
Explain account linking, command failures and skipped delivery
outcomes consistently in both supported languages.
2026-10-23 23:21:31 +08:00
翅膀 7e40d251e8 fix(i18n): bound and cache translation loads
Repeated misses and simultaneous override loads spend KV reads for
the same language. Cache confirmed misses and share bounded loads
without caching read failures as missing translations.
2026-10-23 23:21:30 +08:00
翅膀 372c8522c0 fix(filter): validate executable condition trees
Malformed trees and unsupported patterns must not silently turn an
exclude rule into a pass. Validate the shape and only the patterns
the evaluator actually executes.
2026-10-23 23:21:26 +08:00
翅膀 1b6b30066f fix(filter): read only own payload properties
Inherited object properties are not webhook payload data.
Read own properties only so JSONPath cannot traverse prototypes.
2026-10-23 23:21:25 +08:00
翅膀 900962e003 fix(filter): read each event branch correctly
Deployment and check branches live in event-specific nested fields.
Read those fields and remove only the actual leading ref prefix.
2026-10-23 23:21:21 +08:00
翅膀 125d5eee1f fix(filter): use isolated linear-time patterns
Backtracking patterns can exhaust worker CPU on untrusted payloads.
Use linear-time matching and separate bounded cache namespaces so
glob and regex entries cannot corrupt each other.
2026-10-23 23:21:20 +08:00
翅膀 50966a4c50 fix(storage): preserve claims across kv fallback
Only missing tables justify KV fallback; other failures must surface.
Remember fallback writes so migration to D1 cannot forget claims
and replay completed work. Share marker checks without extra writes.
2026-10-23 23:21:17 +08:00
翅膀 4d5c5e412d test(d1): exercise real sqlite transactions
Exercise real foreign keys, transactions and conditional statements
instead of mocks that cannot reproduce lost updates or cascades.
2026-10-23 23:21:16 +08:00
翅膀 6535126ae0 fix(bot): reject oversized callback bodies
Reject declared oversized bot callbacks before reading their bodies.
This keeps unauthenticated requests from wasting worker resources.
2026-10-23 23:21:15 +08:00
翅膀 c641a8c1c5 fix(runtime): bound shared in-flight waits
A canceled request can leave its shared promise pending forever.
Bound joins and coordinate a single replacement so later requests
make progress without multiplying upstream work.
2026-10-23 23:21:15 +08:00
翅膀 fa83fd79f3 fix(log): preserve structured error details
Error objects lose their useful details when serialized as plain JSON.
Keep the message, stack and cause in structured log output.
2026-10-23 23:21:14 +08:00
翅膀喵 dbf162bf74 feat(admin-console): improve route and filter management (#10)
* fix(nuxt): pre-bundle the CommonJS deps of the markdown stack

`debug` and `extend` are imported by micromark and unified through
@elysola/ui. Served unbundled by the dev server they have no default
export, so the console page failed with a 500 in `nuxt dev`.

* docs(deployment): list the fragments and feishu link migrations

The manual `d1 execute` fallback stopped at 0008, and AGENTS.md named
0001..0010 although 0011 already exists.

* feat(storage): persist the per-group route order

Routes used to load in id order, so the order saved from the console
was lost on the next read. Migration 0012 adds `d1_routes.position`:
saving writes each route's index within its own group (saving one group
never shifts another), and routes load by `group_id, position, id`.

A database without the column keeps working: only a "no such column" /
"has no column named" error falls back to the legacy statements, and
nothing is cached, so a later migration is picked up on the next call.

* feat(console): add in-app destructive-action confirmation

Deleting a route or a group used `window.confirm`, which blocks the page
and ignores the console theme. A promise-based `useConfirm()` now drives
one <ConfirmDialog /> built on the reka-ui AlertDialog that
@elysola/ui ships; reka-ui is pre-bundled so dev keeps a single copy and
the dialog stacks with the Rc dialogs.

A request never outlives its asker: one made after the asking component
unmounted resolves false, and one still open when it unmounts is
cancelled.

* feat(console): confirm member and webhook removal

Removing a member, revoking an invite link and disabling a group's
webhook endpoint took effect on the first click. They now ask first;
disabling the webhook explains that senders still using the secret will
be rejected, and its button is styled as destructive.

* feat(console): confirm removing filled editor rows

Filter conditions and groups, delivery targets, saved fragments and forge
hosts vanished on a single click, taking whatever had been typed with
them. Rows holding content now ask first, while empty, never-filled
rows (`isBlankNode`: default operator, no path, no values, not negated)
are still removed directly.

* fix(i18n): remove duplicate button glyphs

"New Route", "New Group" and the group cards' "Open" link render a Plus
or ArrowRight icon next to their label, so the "+" and "→" baked into
the strings appeared twice.

* style(console): redesign route cards for narrow screens

The card was one flex row whose badges, filter chips, targets and five
hand-drawn icon buttons squeezed the route name on small screens. It is
now a grid driven by a container query: name and actions share the top
line, the filter summary (clamped to two lines) and targets follow, and
the tags wrap below; from 40rem the tags move up beside the title.

Targets of the same platform collapse into one tag with a count, long
ids truncate instead of widening the page, and the actions use lucide
icons with accessible labels.

* feat(console): reorder a group's routes by drag or keyboard

The per-card up/down arrows saved after every single step, so moving a
route five places took five writes. A Reorder mode on the group page now
swaps each card's switch for a drag handle: pointer drags (mouse and
touch) slide the neighbours out of the way and auto-scroll near the
viewport edges, Arrow Up/Down on a focused handle moves a card by one
and is announced to screen readers, and nothing is written until Save
order. Cancel or Escape (unless a dialog or list owns it) drops the
draft.

The cards move into a new RouteList component that owns the drag state.

* style(members): align member cards and invite actions

* style(group-editor): size forge and log target controls

Keep source hosts, platform selectors and remove actions aligned without stretching short controls across the dialog. Wrap component roots explicitly so their internal markup cannot break the grid.

* style(route-editor): group options and delivery target fields

Give each target labeled fields and a compact platform header, widen the filter workspace, and align fragment controls. Scroll failed validation into view when the footer is far from the affected section.

* feat(filters): add bilingual suggestions and value validation

Catalog forge events, actions, payload paths and known values with searchable English and Chinese descriptions. Match-value validation mirrors the server and only rejects inputs that cannot match.

* feat(filters): add searchable creatable value inputs

Build a theme-aligned combobox on the shared reka-ui primitives. Rank stored keys before bilingual descriptions, allow validated custom values, and preserve unconfirmed multi-value drafts instead of silently committing them.

* feat(filter-editor): integrate searchable condition inputs

Replace chip-only values with context-aware bilingual inputs and a compact condition grid. Preserve drafts across tree changes, block saves and tests until drafts are resolved, and keep keyword filters free of hidden operators.

* feat(filters): split pasted values without breaking regexes

Accept multiple values separated by commas or lines while retaining commas inside wrapped expressions and raw regex patterns. Pasting replaces the selected range and keeps rejected values as an explicit draft.

* fix(filters): adapt suggestions to the selected operator

Offer literal prefixes and suffixes for substring operators, escaped anchored patterns for regex, and numeric suggestions only for comparisons. Suggestion syntax must mean what the selected matcher actually reads.

* fix(filters): preserve regex meaning when changing operators

Swap wrapped and raw regex sources only when both compile identically after saving. Leave literal, glob, multiline and Unicode-sensitive comparisons unchanged rather than inventing non-equivalent conversions.

* a11y(filter-editor): label type and operator controls

Associate each fixed select with a stable per-condition label while keeping the compact visual layout unchanged.

* fix(editors): ignore accidental backdrop dismissal

Do not discard unsaved route or group edits when the user clicks outside the dialog. Preserve Escape, Cancel and explicit close, including popovers and confirmation dialogs stacked above the editor.

* feat(dispatch)!: scope stop and fallback to each group

A match in one group must not suppress delivery in another group. Track regular matches and stopped scopes independently, and document the routing-table boundary.

BREAKING CHANGE: stop and fallback no longer apply globally across
groups. Put mutually exclusive routes in the same group and define
fallback routes in each group that needs its own catch-all.

* fix(dispatch): honor stop on a matching fallback route

Once a fallback matches with stop enabled, skip later routes of the same group without affecting other groups. Cover multiple fallback routes in the group-isolation regression test.

* style(console): pin theme and language controls to the right

Separate utility controls from page actions so narrow screens retain a readable title column and right-aligned actions below. Wrap long headings without letting them push controls out of view.

* style(groups): place creation beside the aligned group count

Keep the new-group action inside the group list at every width and align the label and count on one baseline with a consistent type scale.

* style(groups): align card footers and keep role badges intact

Give long names two lines, show the current role in its own non-wrapping row, and anchor every card footer to the grid-row bottom regardless of optional source metadata.

* style(logs): prevent filter labels and metadata overflow

Keep filter labels on one line and allow long channel, thread and repository identifiers to wrap instead of widening the page.

* style(console): scale the sidebar and hide mobile tab tracks

Narrow the sidebar proportionally while retaining enough room for both locales. Keep mobile navigation swipeable without a visible horizontal scrollbar.

* feat(console): give each group its own routes URL

Resolve the selected group from /admin/groups/{groupId}, validate console paths, and use browser history for back navigation. Keep Groups active and let an active mobile-tab tap return to the list. Scope pending route loads to their group and retain the count beside long headings.

* feat(console): confirm leaving unsaved page work

Guard route changes when an editor or changed order draft is open. Cancel superseded questions and restore the shown history entry when repeated Back or Forward navigation is refused; only completed navigation resets page work.

* feat(console): confirm sign-out from desktop and mobile

Expose sign-out in the mobile topbar when the sidebar is hidden. Both entry points use the in-app confirmation before navigating to the server logout endpoint.

* fix(console): keep topbar tools clear of very narrow headings

Below 360px, place the full-width heading beneath the breadcrumb and utility row so the three top-right buttons cannot overlap it.

* feat(console): prioritize group titles over actions

Place New Route after Reorder in the group bar. Measure available space and remove the reorder label first, then the creation label, before truncating the group title; remeasure on resize, locale and font changes.

* fix(editors): focus the dialog without selecting its name field

Cancel the non-bubbling FocusScope mount event in the capture phase and focus the dialog itself. Keep keyboard navigation working without highlighting the name or opening the touch keyboard automatically.

* perf(console): preserve one instance across admin navigation

Use a fixed page key instead of remounting the whole console for each URL. Refresh each view when shown and isolate overview metrics and logs so page filters cannot leak into the dashboard.

* fix(console-data): discard superseded load responses

Only the latest request may update a list, its error or loading state. Invalidate pending group loads after a save so an older response cannot restore stale configuration during persistent-console navigation.

* fix(routes): serialize writes and reject unloaded route lists

Whole-list saves must start from loaded data and wait for other route writes. Lock switches and actions during saves, recheck deletion after confirmation, and rebuild saved ordering from the newest route objects.

* fix(editors): scope async results and fragment writes to sessions

A completed save or dry run must not close or overwrite a newer editor. Keep fragment state scoped by group, reject writes until the real list is ready, and retain in-flight fragment locks across navigation.

* fix(groups): serialize edits and isolate group detail panels

Prevent overlapping whole-list writes, avoid duplicate ids after rename, and discard delete confirmations prepared on a page that has since been left. Key member and webhook panels by group so local state cannot cross tenants.

* fix(console): omit the empty action row outside overview

Render the refresh-action container only where it has content so narrow layouts do not reserve a blank row after creation controls move into their page bars.

* perf(metrics): send all seven queries in one D1 batch

Avoid seven sequential network round trips and read totals, breakdowns and recent failures in one consistent transaction. Reuse the failed-send statement and row mapping while retaining group scoping.

* fix(admin-api): bypass browser cache locks for live requests

Use no-store on both client requests and admin responses. Personalized live data must not be reused, and one stalled same-URL cache entry must not block later log requests behind the browser cache lock.

* docs(routes): Clarify fallback hints and document group-scoped stop and fallback upgrade behavior
2026-10-17 21:13:20 +08:00
github-actions[bot] 29b15f4933 chore: auto-fix lint & formatting [skip ci] 2026-10-17 03:37:45 +00:00
RhenCloud 2281c19939 refactor: rebrand WebHooker as Elysola 2026-10-17 11:37:02 +08:00
RhenCloud 0d5c62d5db fix(console): use standard i18n key for group card routes label 2026-10-04 20:58:28 +08:00
github-actions[bot] 4dc533c7fa chore: auto-fix lint & formatting [skip ci] 2026-10-03 16:06:19 +00:00
RhenCloud c9afd8639a style(console): refine route and group cards layout and remove duplicate back arrow 2026-10-04 00:05:37 +08:00
github-actions[bot] 37d2eb3636 chore: auto-fix lint & formatting [skip ci] 2026-10-03 14:55:16 +00:00
RhenCloud fbbff669a3 feat(ui): migrate to @recloudstudio/ui, add theme toggle and polish console UX 2026-10-03 22:54:32 +08:00
RhenCloud a899e16604 fix(ci): scope auto-fix commits and ignore artifacts 2026-10-02 21:31:53 +08:00
github-actions[bot] 0e2e30ae1a chore: auto-fix lint & formatting [skip ci] 2026-10-02 21:18:20 +08:00
RhenCloud 3567c6d321 fix(formatter): link branch and tag titles 2026-10-01 18:40:02 +08:00
RhenCloud b7fd31a665 fix(push): handle unresolved bot authors 2026-10-01 18:33:17 +08:00
RhenCloud 1057a60de7 fix(push): show differing commit author 2026-09-30 18:52:07 +08:00
wyf9 5fd1709f0f chore: signed actions commit 2026-09-30 18:44:10 +08:00
RhenCloud 2db56d63c7 feat(brand): add fishhook logo and wire up favicon 2026-09-26 17:00:51 +08:00
RhenCloud 968ad3d2f3 fix(admin): avoid duplicate platform key in route target normalization
Merging the blank target and stored target before normalizing the
platform keeps the bundler from inlining blankTarget() into the same
object literal, which emitted a duplicate-object-key warning.
2026-09-26 16:23:00 +08:00
github-actions[bot] 05ede2aa03 chore: auto-fix lint & formatting [skip ci] 2026-09-26 08:03:37 +00:00
RhenCloud 2891e1f33c fix(github): send User-Agent header on GitHub API requests
GitHub rejects API requests without a User-Agent (403), and Workers'
fetch does not set one by default, so workflow job enrichment and
check-suite build-log lookups silently failed in production.
2026-09-26 16:02:27 +08:00
RhenCloud 027ca2bcca fix(dispatch): hoist workflow jobs memoization above route loop
The workflow_jobsPromise declaration sat after the route dispatch loop,
so processRoute hit a temporal dead zone ReferenceError for
workflow_run events; Promise.allSettled swallowed it and no message was
sent. Move the memoized enrichment above the loop and add a regression
test that dispatches a workflow_run event with jobs enrichment.
2026-09-26 15:52:32 +08:00
github-actions[bot] e8d7455a2b chore: auto-fix lint & formatting [skip ci] 2026-09-26 07:33:49 +00:00
RhenCloud 04352c3a19 feat(github): fetch workflow_run jobs via jobs_url enrichment
The workflow_run webhook payload carries no jobs array, only jobs_url,
so the Jobs field never populated for real GitHub events. Fetch the job
list from the GitHub API once per delivery (lazy, memoized across
routes) and inject it into the payload before formatting.

- app-token.ts: shared getInstallationToken (App JWT -> installation
  token) + GITHUB_API_VERSION; check-run.ts now reuses it
- workflow-jobs.ts: getWorkflowRunJobs, App token when configured else
  unauthenticated (public repos), per_page=100, best-effort
- docs: GitHub App needs Actions: read; note API enrichment in the
  message-format and supported-events guides (en + zh)
2026-09-26 15:33:06 +08:00
github-actions[bot] ae36c22fda chore: auto-fix lint & formatting [skip ci] 2026-09-26 06:58:56 +00:00
RhenCloud e607d41432 feat(workflow): render workflow_run jobs as colored diff block
List each job on its own line with a status emoji and, for completed
jobs, the duration. Discord colors the diff fence: '+' green for
success, '-' red for other finished conclusions, plain for
running/queued/pending. Telegram/Feishu collapse it to inline code.

Sync AGENTS.md, README(s), docs guide and supported-events tables.
2026-09-26 14:58:00 +08:00
github-actions[bot] 4e81d3d4da chore: auto-fix lint & formatting [skip ci] 2026-09-13 05:13:36 +00:00
RhenCloud 2e89c79e9c fix(telegram): render rich header title as plain text 2026-09-13 13:13:09 +08:00
github-actions[bot] 1348873847 chore: auto-fix lint & formatting [skip ci] 2026-09-10 14:36:24 +00:00
RhenCloud 1a0500b812 fix: prevent data loss in routes, fragments, and group operations
Found and fixed multiple critical bugs with similar patterns:

1. routeStatements() used DELETE FROM d1_routes before re-inserting
   - Could cause data loss if interrupted or if logic changes
   - Now uses DELETE with WHERE clause + INSERT...ON CONFLICT (upsert)

2. saveFragments() used DELETE FROM d1_fragments before re-inserting
   - Same pattern as routes, fixed with targeted deletes + upsert
   - Added loadFragments() call to determine what to delete

3. adminGroupRename() didn't update fragment groupId
   - When renaming a group, fragments were left pointing to old groupId
   - Now updates fragments alongside routes, secrets, and invites

All changes follow the same safe pattern:
- Load existing data to identify what needs deletion
- Delete only removed items with WHERE clauses
- Use INSERT...ON CONFLICT DO UPDATE for upserts
- Never use bare DELETE FROM table

Testing: All 339 tests pass.
2026-09-10 22:35:43 +08:00