Files
WebHooker/tests/telegram-commands.test.ts
T
翅膀喵andRhenCloud 978c53eeb3 fix(security): harden webhook delivery pipeline and group storage (#11)
* fix(log): preserve structured error details

Error objects lose their useful details when serialized as plain JSON.
Keep the message, stack and cause in structured log output.

* fix(runtime): bound shared in-flight waits

A canceled request can leave its shared promise pending forever.
Bound joins and coordinate a single replacement so later requests
make progress without multiplying upstream work.

* fix(bot): reject oversized callback bodies

Reject declared oversized bot callbacks before reading their bodies.
This keeps unauthenticated requests from wasting worker resources.

* test(d1): exercise real sqlite transactions

Exercise real foreign keys, transactions and conditional statements
instead of mocks that cannot reproduce lost updates or cascades.

* fix(storage): preserve claims across kv fallback

Only missing tables justify KV fallback; other failures must surface.
Remember fallback writes so migration to D1 cannot forget claims
and replay completed work. Share marker checks without extra writes.

* fix(filter): use isolated linear-time patterns

Backtracking patterns can exhaust worker CPU on untrusted payloads.
Use linear-time matching and separate bounded cache namespaces so
glob and regex entries cannot corrupt each other.

* fix(filter): read each event branch correctly

Deployment and check branches live in event-specific nested fields.
Read those fields and remove only the actual leading ref prefix.

* fix(filter): read only own payload properties

Inherited object properties are not webhook payload data.
Read own properties only so JSONPath cannot traverse prototypes.

* fix(filter): validate executable condition trees

Malformed trees and unsupported patterns must not silently turn an
exclude rule into a pass. Validate the shape and only the patterns
the evaluator actually executes.

* fix(i18n): bound and cache translation loads

Repeated misses and simultaneous override loads spend KV reads for
the same language. Cache confirmed misses and share bounded loads
without caching read failures as missing translations.

* i18n(bot): explain command and account failures

Explain account linking, command failures and skipped delivery
outcomes consistently in both supported languages.

* fix(github): bound and reuse app token fetches

Repeated token exchanges waste requests and JWT work for every event.
Reuse valid installation tokens, share refreshes and back off briefly
after failures while keeping every shared wait bounded.

* fix(github): restrict enrichment request urls

Webhook-provided URLs must never receive an installation token on
another host. Restrict enrichment to GitHub repository API paths,
reject redirects and bound optional requests.

* fix(formatter): preserve invalid code points

Out-of-range numeric entities can throw while formatting a delivery.
Keep invalid code points verbatim instead of aborting the message.

* fix(formatter): preserve bounded markdown text

Code spans, fences, indentation and autolinks are Markdown content,
not HTML tags to strip. Preserve them while bounding cleanup input
and reusing results across routes for the same event.

* fix(formatter): strip only leading ref prefixes

A short branch or tag may itself contain refs/heads or refs/tags.
Strip one leading full-ref prefix at the caller and keep short names
unchanged when generating labels and links.

* fix(gitea): link push authors to their forge

A Gitea author is not the same-named GitHub account.
Build author profile links from the originating forge.

* fix(formatter): render deployment state values

The deployment status object stringifies as [object Object].
Render its actual state in the status field.

* fix(formatter): read security severity levels

The scanner severity is not the security severity of an alert.
Prefer the security level so critical and high alerts get the right
label and color.

* fix(formatter): hide actions on other forges

Action buttons call the GitHub API as the linked user.
Hide them for other forges to avoid operating on a same-named
GitHub repository.

* fix(check): isolate updates by check suite

Same-named checks from different suites must not edit one message.
Include the suite or app identity and retain the former key for
controlled adoption of existing tracked messages.

* fix(logs): scope queries before limiting results

Filter authorized groups in SQL before LIMIT and aggregate only
visible rows. Preserve current group attribution for late writes,
surface read failures and combine related totals in one scan.

* perf(d1): index pruning and failed send queries

Pruning and failure views should not scan all historical rows.
Index the high-value access paths without adding a write-heavy
index for infrequent delivery-detail lookups.

* fix(discord): bound individual api requests

An unbounded API request can outlive an update-chain lock.
Bound each request so another holder cannot race a late edit.

* fix(discord): defer long rate-limit waits

Long rate-limit sleeps block delivery progress inside a worker.
Return a retryable 429 for the queue when the wait exceeds the bound.

* fix(discord): encode channel path segments

Stored channel and message ids are path segments, not URL paths.
Encode them so aliases cannot address another Discord resource.

* fix(discord): reuse nonces after lost responses

A successful create may lose its response. Reuse a stable nonce
with enforce_nonce so retries recover that message instead of
posting duplicates or accepting an unreadable success.

* fix(discord): constrain embeds and role mentions

Respect combined embed and component limits as well as field caps.
Restrict allowed mentions to validated route roles so payload text
cannot notify everyone.

* fix(discord): resume bounded command syncs

Application changes, command rollbacks and large guild lists can
leave commands stale indefinitely. Track the current hash per app
and resume bounded paginated work without needless KV writes.

* fix(github): verify installation management

An installation id is user-controlled, and repository access is not
installation management. Verify the owning account or an active
organization admin using the user token and read:org scope.

* fix(github): resolve immutable member ids

A login can be renamed and reclaimed before its first sign-in.
Resolve the current immutable user id when membership is granted
so a future holder of the login cannot inherit access.

* fix(auth): revoke stale sessions and tokens

Revoked or rotated credentials must stop working despite stale KV
replicas. Track the live token and revocations in D1 and preserve
immutable identity bindings rather than trusting a recycled login.

* fix(auth): bind sessions and tokens to identity

Automatic retries can repeat non-idempotent user actions.
Disable those retries and expose a write hook so bot handlers can
record completion immediately before the GitHub write.

* fix(discord): defer and deduplicate interactions

Acknowledge slow actions before Discord times out and deduplicate
interaction writes. Preserve comment text and reject edits whose
source changed after the modal opened.

* fix(telegram): always verify webhook secrets

Webhook verification must not silently disable itself when the
optional secret is absent. Derive a stable secret from the bot
token and reject callbacks when verification is unavailable.

* fix(telegram): bound individual api requests

Bound individual platform calls so they cannot outlive the lock
protecting a message update or stall a whole delivery invocation.

* fix(telegram): honor nested rate-limit delays

Telegram places retry_after inside parameters, not at the top level.
Read that value and defer long waits to the delivery queue.

* fix(telegram): report unreadable send results

An unreadable successful response may already have sent the message.
Report an explicit uncertain result instead of retrying a create
without an idempotency key or pretending it succeeded.

* fix(telegram): keep editable messages as text

Guessing photo versus text from message content makes later edits
use the wrong API and a smaller caption budget. Always send text
and use the avatar as a link preview.

* fix(telegram): render hard breaks as newlines

Telegram HTML does not support br tags. Render Markdown hard breaks
as plain newlines so otherwise valid messages are accepted.

* fix(telegram): clamp visible html characters

Telegram counts visible characters, not HTML source bytes.
Truncate without splitting tags, entities or surrogate pairs.

* fix(telegram): honor the author emoji toggle

The author marker must obey the group emoji preference just like
formatter-added decoration.

* fix(telegram): keep completed commands claimed

Redelivery after a completed write must never post another comment.
Keep completion claims despite reply failures, scope updates per bot
and only issue account-login links in private chats.

* fix(feishu): bound individual api requests

Bound individual platform calls so they cannot outlive the lock
protecting a message update or stall a whole delivery invocation.

* fix(feishu): classify retryable api failures

Business error codes can be transient even in HTTP 200 responses.
Classify token and rate-limit errors for retry and defer long waits.

* fix(feishu): retry sends with stable uuids

An unreadable response does not prove a send failed.
Reuse the same uuid for retries so recovering the result cannot
create a second Feishu message.

* fix(feishu): refresh and evict tokens safely

Separate app token caches, stop reusing refused tokens and share
refreshes. Cache failures briefly and keep valid tokens in memory
when a best-effort KV cache write fails.

* fix(feishu): use the card update endpoint

Delayed card updates use the card update endpoint; the config
endpoint cannot update an interaction response.

* fix(feishu): neutralize untrusted mentions

Forge text is untrusted and can contain at-all tags.
Neutralize mentions in card bodies and footers before rendering.

* fix(feishu): authenticate and dedupe callbacks

Authenticate signed or token-verified callbacks before dispatching
commands. Decode encrypted envelopes and handle card actions using
the correct fields without claiming irrelevant chat events.

* fix(target): normalize actual destinations

Different target spellings can name the same actual destination.
Normalize channel, thread and topic identities for ownership checks
and per-route duplicate suppression.

* fix(config): transact per-group configuration

Whole-table writes and cached snapshots can overwrite other groups
or resurrect removed configuration. Use per-group guarded writes,
one-time identity migration and explicit unreadable-row failures.

* fix(group): preserve identity through lifecycle

Group names are mutable and reusable, so they cannot own durable
state. Preserve immutable identities across lifecycle operations and
commit invite use with membership under transaction-time guards.

* fix(oauth): confirm account links and installs

A login link or installation id is not proof of account ownership.
Verify installation management, bind browser state and require an
explicit account-link confirmation before granting chat access.

* fix(queue): fence leases and record target outcomes

Retries must remember completed targets and distinguish active
lease holders. Fence state updates, preserve permanent outcomes and
reject missing parked payloads instead of dispatching empty data.

* fix(dispatch): isolate and resume tenant sends

Check tenant sources before filters and never dispatch orphan routes.
Record each target outcome, isolate update chains by forge and group
identity, and keep stale events from overwriting newer messages.

* fix(queue): bound batches and resume deliveries

A queue invocation has shared query and subrequest limits.
Use a small batch and shared send budget, renew fenced leases and
resume only unfinished work without exhausting unstarted messages.

* fix(admin): guard revisions and tenant targets

Read-time authorization alone cannot protect concurrent edits.
Guard revisions, current roles and destination ownership in the
write transaction, and use per-group endpoints for isolated changes.

* fix(webhook): confirm only accepted deliveries

Acknowledging before queue acceptance permanently loses deliveries.
Confirm only accepted work, release failed claims, scope replay
identities and strip tenant-supplied installation authority.

* fix(storage): prune abandoned parked payloads

Oversized payloads can remain after interrupted enqueue attempts.
Prune objects beyond their retry lifetime without deleting payloads
that a current delivery may still need.

* fix(console): expose api conflict statuses

Callers need the HTTP status to distinguish stale edits from other
failures and reload current data after a conflict.

* refactor(console): model group revisions

Carry server revisions explicitly so console writes can reject
changes based on an outdated group snapshot.

* fix(console): send loaded route revisions

Send the revision actually loaded with the route list and adopt the
server response after a save. Reload on conflict instead of silently
overwriting another editor.

* fix(console): guard fragment saves by revision

Fragments share a group version with other configuration writes.
Submit the loaded revision and reload on conflict to preserve
concurrent edits.

* fix(console): save groups with guarded writes

Whole-list saves can overwrite unrelated groups. Use per-group
revision-aware writes, retain rename results and confirm deletion
on the exact group, routes and version shown to the user.

* fix(console): reject edits of stale routes

A conflict reload can leave an older route editor open.
Compare its original value before saving so it cannot overwrite
the newly loaded route.

* fix(console): show overview loading failures

Failed overview requests must not look like an empty dashboard or
a successful refresh. Show the reason while retaining prior data.

* fix(console): explain rejected install bindings

Explain why an installation binding was refused instead of silently
returning to the console with no visible outcome.

* fix(console): allow selecting a group named all

The all sentinel collides with a valid group id.
Use a value that cannot be a group id so that group stays selectable.

* fix(console): discard stale log detail responses

An older detail request can finish after a newer selection or close.
Discard it so the dialog never shows the previously clicked record.

* fix(console): retain legacy group owners

Groups predating member roles store owners in adminIds.
Load those as owners so adding a member never drops all old owners.

* fix(console): lock member edits during saves

Edits made during a save are overwritten by its result.
Disable member controls and guard handlers until the write settles.

* fix(console): show invite loading failures

Failed invite loads must not look like no pending invites.
Show the error and discard responses from a previously shown group.

* fix(console): retain legacy discord log targets

A stored log target without platform means Discord.
Keep that meaning in the editor instead of clearing the target.

* fix(console): retain undisplayed forge sources

An editor that only displays some providers must preserve the others.
Keep stored custom sources when saving unrelated group settings.

* fix(console): lock the group editor while saving

Prevent edits while a group save is in flight and make super-only
installation settings readonly instead of silently ignoring edits.

* fix(console): lock route edits and show failures

Lock the route editor while saving and show fragment load failures
with a retry action rather than presenting a false empty list.

* fix(config): expose the legal contact override

Declare the public runtime key so the documented environment
override reaches legal pages in deployed Nuxt builds.

* build(deploy): migrate d1 before deployment

Apply pending D1 migrations before deploying code that requires
them. Stop deployment when migration fails instead of running
against an incomplete schema.

* docs(worker): align guides with runtime behavior

Synchronize both language guides, API references and examples with
the implemented authorization, storage and delivery behavior.
Document migration requirements and accepted operational limits.

* fix(storage): repair orphaned KV routes

Repair orphaned KV routes before serving KV-only configuration.

* fix(security): fully escape forge HTML

---------

Co-authored-by: RhenCloud <i@rhen.cloud>
2026-10-24 16:19:06 +08:00

642 lines
23 KiB
TypeScript

import { describe, it, expect, afterEach } from "bun:test";
import { handleTelegramUpdate } from "../server/lib/drivers/telegram/commands";
import { handleTelegramWebhookRequest } from "../server/lib/drivers/telegram/updates";
import type { Env } from "../server/lib/types";
function mockFetch(handler: (url: string, init?: RequestInit) => Response): void {
globalThis.fetch = (input: RequestInfo | URL, init?: RequestInit): Promise<Response> =>
Promise.resolve(handler(String(input), init));
}
const restoredFetch = globalThis.fetch;
afterEach(() => {
globalThis.fetch = restoredFetch;
});
function createMockKV(): KVNamespace {
const store = new Map<string, string>();
return {
get: async (key: string, type?: string) => {
const v = store.get(key);
if (v === undefined) return null;
return type === "json" ? JSON.parse(v) : v;
},
put: async (key: string, value: string) => {
store.set(key, value);
},
delete: async (key: string) => {
store.delete(key);
},
list: async () => ({ keys: [] }),
} as unknown as KVNamespace;
}
function createMockDB(): D1Database {
const links = new Map<string, string>();
return {
prepare: (sql: string) => ({
bind: (...args: unknown[]) => ({
run: async (): Promise<{ success: boolean }> => {
const m = sql.match(
/INSERT OR REPLACE INTO telegram_links \(telegram_user_id, github_user_id\) VALUES \(\?, \?\)/,
);
if (m) links.set(String(args[0]), String(args[1]));
const del = sql.match(/DELETE FROM telegram_links WHERE telegram_user_id = \?/);
if (del) links.delete(String(args[0]));
return { success: true };
},
all: async (): Promise<{ results: Array<Record<string, unknown>> }> => {
const sel = sql.match(
/SELECT github_user_id FROM telegram_links WHERE telegram_user_id = \?/,
);
if (sel) {
const val = links.get(String(args[0]));
return { results: val ? [{ github_user_id: val }] : [] };
}
return { results: [] };
},
first: async () => null,
}),
}),
} as unknown as D1Database;
}
function createEnv(): Env {
return {
GITHUB_WEBHOOK_SECRET: "secret",
GITHUB_CLIENT_ID: "client-id",
TELEGRAM_TOKEN: "tg-token",
TELEGRAM_WEBHOOK_SECRET: "wh-secret",
KV: createMockKV(),
DB: createMockDB(),
} as Env;
}
function reply(chatId: string, topicId?: number): Record<string, unknown> {
return {
message_id: 1,
from: { id: 111, first_name: "Rhen" },
chat: { id: chatId, type: "supergroup" },
message_thread_id: topicId,
};
}
describe("telegram-commands /gh login", () => {
it("only hands out the OAuth link in the private chat", async () => {
let sentBody: Record<string, unknown> | undefined;
mockFetch((_url, init) => {
sentBody = JSON.parse(String(init!.body)) as Record<string, unknown>;
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), { status: 200 });
});
const env = createEnv();
await handleTelegramUpdate(env, {
message: { ...reply("-100123"), text: "/gh login" },
});
expect(sentBody?.chat_id).toBe("-100123");
expect(String(sentBody?.text)).not.toContain("github.com/login/oauth/authorize");
await handleTelegramUpdate(env, {
message: {
...reply("42"),
chat: { id: 42, type: "private" },
text: "/gh login",
},
});
expect(sentBody?.chat_id).toBe("42");
expect(String(sentBody?.text)).toContain("github.com/login/oauth/authorize");
});
it("runs a redelivered update only once", async () => {
let calls = 0;
mockFetch(() => {
calls++;
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), { status: 200 });
});
const env = createEnv();
const update = { update_id: 99, message: { ...reply("-100123"), text: "/gh logout" } };
await handleTelegramUpdate(env, update);
await handleTelegramUpdate(env, update);
expect(calls).toBe(1);
});
});
describe("telegram-commands /gh logout", () => {
it("replies bound/unbound message", async () => {
let sentText = "";
mockFetch((_url, init) => {
sentText = String((JSON.parse(String(init!.body)) as Record<string, unknown>).text);
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), { status: 200 });
});
const env = createEnv();
await handleTelegramUpdate(env, {
message: { ...reply("-100123"), text: "/gh logout" },
});
expect(sentText).toContain("已解绑");
});
});
describe("telegram-commands /gh comment", () => {
it("replies when no reply_to_message link present", async () => {
let sentText = "";
mockFetch((_url, init) => {
sentText = String((JSON.parse(String(init!.body)) as Record<string, unknown>).text);
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), { status: 200 });
});
const env = createEnv();
await handleTelegramUpdate(env, {
message: { ...reply("-100123"), text: "/gh comment hello" },
});
expect(sentText).toContain("还没有绑定");
});
it("parses the replied-to GitHub link as target", async () => {
const env = createEnv();
const { saveTelegramLink } = await import("../server/lib/github/store");
await saveTelegramLink(env.DB, "111", "111980217");
await env.KV.put(
"token:111980217",
JSON.stringify({
userId: "111980217",
accessToken: "ghu_test",
expiresAt: Date.now() + 3600_000,
}),
);
const calls: Array<{ url: string; body: string }> = [];
mockFetch((url, init) => {
calls.push({ url, body: String(init!.body) });
if (String(url).endsWith("/sendMessage")) {
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), {
status: 200,
});
}
return new Response(
JSON.stringify({ html_url: "https://github.com/acme/widget/issues/7#issuecomment-9" }),
{ status: 200 },
);
});
await handleTelegramUpdate(env, {
message: {
...reply("-100123"),
text: "/gh comment hello",
reply_to_message: {
...reply("-100123"),
text: "acme/widget#7: Add feature",
entities: [{ type: "text_link", url: "https://github.com/acme/widget/issues/7" }],
},
},
});
const ghCall = calls.find((c) => c.url.includes("/repos/"));
expect(ghCall).toBeDefined();
expect(ghCall!.url).toContain("/repos/acme/widget/issues/7/comments");
const ghBody = JSON.parse(ghCall!.body) as Record<string, unknown>;
expect(ghBody.body).toBe("hello");
});
});
describe("telegram-updates webhook", () => {
it("rejects requests without the secret token", async () => {
const env = createEnv();
const res = await handleTelegramWebhookRequest(
new Request("https://example.com/telegram/webhook", { method: "POST", body: "{}" }),
env,
);
expect(res.status).toBe(401);
});
it("accepts requests with the correct secret token", async () => {
mockFetch(
() => new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), { status: 200 }),
);
const env = createEnv();
const res = await handleTelegramWebhookRequest(
new Request("https://example.com/telegram/webhook", {
method: "POST",
headers: { "X-Telegram-Bot-Api-Secret-Token": "wh-secret" },
body: JSON.stringify({ update_id: 1 }),
}),
env,
);
expect(res.status).toBe(200);
expect(await res.text()).toBe("ok");
});
});
describe("telegram-commands addressed by bot name", () => {
it("runs `/gh@ThisBot` and ignores a command addressed to another bot", async () => {
const sent: string[] = [];
mockFetch((url, init) => {
if (url.endsWith("/getMe")) {
return new Response(JSON.stringify({ ok: true, result: { username: "ReviewBot" } }), {
status: 200,
});
}
sent.push(String((JSON.parse(String(init!.body)) as Record<string, unknown>).text));
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), { status: 200 });
});
const env = createEnv();
await handleTelegramUpdate(env, {
message: { ...reply("-100123"), text: "/gh@reviewbot logout" },
});
expect(sent).toHaveLength(1);
await handleTelegramUpdate(env, {
message: { ...reply("-100123"), text: "/gh@OtherBot logout" },
});
expect(sent).toHaveLength(1);
});
});
describe("telegram-commands replies", () => {
it("gives an update back when its reply could not be sent", async () => {
let sends = 0;
mockFetch(() => {
sends++;
return new Response(JSON.stringify({ ok: false, description: "Bad Gateway" }), {
status: 502,
});
});
const env = createEnv();
const update = {
update_id: 501,
message: { ...reply("42"), chat: { id: 42, type: "private" }, text: "/gh login" },
};
await expect(handleTelegramUpdate(env, update)).rejects.toThrow();
mockFetch(() => {
sends++;
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), { status: 200 });
});
// Telegram's redelivery runs it again: the link is sent this time.
await handleTelegramUpdate(env, update);
expect(sends).toBeGreaterThan(1);
});
it("keeps a comment's line breaks and indentation", async () => {
const env = createEnv();
const { saveTelegramLink } = await import("../server/lib/github/store");
await saveTelegramLink(env.DB, "111", "111980217");
await env.KV.put(
"token:111980217",
JSON.stringify({
userId: "111980217",
accessToken: "ghu_test",
expiresAt: Date.now() + 3600_000,
}),
);
const calls: Array<{ url: string; body: string }> = [];
mockFetch((url, init) => {
calls.push({ url, body: String(init!.body) });
if (String(url).endsWith("/sendMessage")) {
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), {
status: 200,
});
}
return new Response(
JSON.stringify({ html_url: "https://github.com/acme/widget/issues/7#issuecomment-9" }),
{ status: 200 },
);
});
await handleTelegramUpdate(env, {
message: {
...reply("-100123"),
text: "/gh comment first line\n indented\n\n- item",
reply_to_message: {
...reply("-100123"),
text: "acme/widget#7: Add feature",
entities: [{ type: "text_link", url: "https://github.com/acme/widget/issues/7" }],
},
},
});
const ghCall = calls.find((c) => c.url.includes("/repos/"));
expect((JSON.parse(ghCall!.body) as { body: string }).body).toBe(
"first line\n indented\n\n- item",
);
});
});
describe("telegram-commands refusals and whitespace", () => {
it("gives back a command GitHub never ran when its error reply fails", async () => {
const env = createEnv();
const { saveTelegramLink } = await import("../server/lib/github/store");
// Linked, but no token: refused before any GitHub request.
await saveTelegramLink(env.DB, "111", "111980217");
let replies = 0;
let github = 0;
mockFetch((url) => {
if (url.includes("api.github.com")) github++;
replies++;
return new Response(JSON.stringify({ ok: false, description: "Bad Gateway" }), {
status: 502,
});
});
const update = {
update_id: 777,
message: {
...reply("-100123"),
text: "/gh comment hello",
reply_to_message: {
...reply("-100123"),
text: "acme/widget#7: Add feature",
entities: [{ type: "text_link", url: "https://github.com/acme/widget/issues/7" }],
},
},
};
await expect(handleTelegramUpdate(env, update)).rejects.toThrow();
// Not confirmed: the redelivery runs it (and replies) again.
await expect(handleTelegramUpdate(env, update)).rejects.toThrow();
expect(github).toBe(0);
expect(replies).toBeGreaterThan(1);
});
it("keeps an indented first line of a comment", async () => {
const env = createEnv();
const { saveTelegramLink } = await import("../server/lib/github/store");
await saveTelegramLink(env.DB, "111", "111980217");
await env.KV.put(
"token:111980217",
JSON.stringify({
userId: "111980217",
accessToken: "ghu_test",
expiresAt: Date.now() + 3600_000,
}),
);
const calls: Array<{ url: string; body: string }> = [];
mockFetch((url, init) => {
calls.push({ url, body: String(init!.body) });
if (String(url).endsWith("/sendMessage")) {
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), {
status: 200,
});
}
return new Response(
JSON.stringify({ html_url: "https://github.com/acme/widget/issues/7#issuecomment-9" }),
{ status: 200 },
);
});
await handleTelegramUpdate(env, {
message: {
...reply("-100123"),
text: "/gh comment\n code()",
reply_to_message: {
...reply("-100123"),
text: "acme/widget#7: Add feature",
entities: [{ type: "text_link", url: "https://github.com/acme/widget/issues/7" }],
},
},
});
const ghCall = calls.find((c) => c.url.includes("/repos/"));
expect((JSON.parse(ghCall!.body) as { body: string }).body).toBe(" code()");
});
});
describe("telegram-commands done before the write", () => {
it("records the command as done before GitHub is written to", async () => {
const env = createEnv();
const { saveTelegramLink } = await import("../server/lib/github/store");
await saveTelegramLink(env.DB, "111", "111980217");
await env.KV.put(
"token:111980217",
JSON.stringify({
userId: "111980217",
accessToken: "ghu_test",
expiresAt: Date.now() + 3600_000,
}),
);
let doneAtWrite: unknown = "unset";
// Storage touches of the "done" record (each is a quota operation).
let doneTouches = 0;
const kvGet = env.KV.get.bind(env.KV);
env.KV.get = (async (key: string, ...rest: unknown[]) => {
if (key === "accepted:bot:telegram:tg-token:888") doneTouches++;
return (kvGet as (...a: unknown[]) => Promise<unknown>)(key, ...rest);
}) as KVNamespace["get"];
globalThis.fetch = (async (input: RequestInfo | URL, init?: RequestInit) => {
const url = String(input instanceof Request ? input.url : input);
const method = input instanceof Request ? input.method : (init?.method ?? "GET");
if (url.includes("/comments") && method === "POST") {
doneAtWrite = await kvGet("accepted:bot:telegram:tg-token:888");
}
if (url.endsWith("/sendMessage")) {
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), {
status: 200,
});
}
return new Response(
JSON.stringify({
login: "a",
html_url: "https://github.com/acme/widget/issues/7#issuecomment-9",
}),
{ status: 200 },
);
}) as typeof fetch;
await handleTelegramUpdate(env, {
update_id: 888,
message: {
...reply("-100123"),
text: "/gh comment hello",
reply_to_message: {
...reply("-100123"),
text: "acme/widget#7: Add feature",
entities: [{ type: "text_link", url: "https://github.com/acme/widget/issues/7" }],
},
},
});
// A lost confirmation afterwards can no longer let a redelivery write again.
expect(doneAtWrite).not.toBeNull();
expect(doneAtWrite).not.toBe("unset");
// Written once, before the write — not confirmed a second time after it
// (which would touch the record once more).
expect(doneTouches).toBe(3);
});
});
describe("telegram-commands outlived claims", () => {
it("writes nothing once another run finished the same update", async () => {
const env = createEnv();
const { saveTelegramLink } = await import("../server/lib/github/store");
await saveTelegramLink(env.DB, "111", "111980217");
await env.KV.put(
"token:111980217",
JSON.stringify({
userId: "111980217",
accessToken: "ghu_test",
expiresAt: Date.now() + 3600_000,
}),
);
let posted = 0;
// Meanwhile (this run outlived its claim, reading its token) another run
// finished it.
const kvGet = env.KV.get.bind(env.KV);
env.KV.get = (async (key: string, ...rest: unknown[]) => {
if (key === "token:111980217")
await env.KV.put("accepted:bot:telegram:tg-token:999", "other-run");
return (kvGet as (...a: unknown[]) => Promise<unknown>)(key, ...rest);
}) as KVNamespace["get"];
globalThis.fetch = (async (input: RequestInfo | URL, init?: RequestInit) => {
const url = String(input instanceof Request ? input.url : input);
const method = input instanceof Request ? input.method : (init?.method ?? "GET");
if (url.includes("/comments") && method === "POST") posted++;
if (url.endsWith("/sendMessage")) {
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), {
status: 200,
});
}
return new Response(
JSON.stringify({
login: "a",
html_url: "https://github.com/acme/widget/issues/7#issuecomment-9",
}),
{ status: 200 },
);
}) as typeof fetch;
await handleTelegramUpdate(env, {
update_id: 999,
message: {
...reply("-100123"),
text: "/gh comment hello",
reply_to_message: {
...reply("-100123"),
text: "acme/widget#7: Add feature",
entities: [{ type: "text_link", url: "https://github.com/acme/widget/issues/7" }],
},
},
});
expect(posted).toBe(0);
// The other run's "done" stays.
expect(await env.KV.get("accepted:bot:telegram:tg-token:999")).toBe("other-run");
});
});
describe("telegram-commands foreign done markers", () => {
it("never gives back a done another run wrote, even when its own read failed", async () => {
const env = createEnv();
const { saveTelegramLink } = await import("../server/lib/github/store");
await saveTelegramLink(env.DB, "111", "111980217");
await env.KV.put(
"token:111980217",
JSON.stringify({
userId: "111980217",
accessToken: "ghu_test",
expiresAt: Date.now() + 3600_000,
}),
);
// Another run finished meanwhile; this run's token read then fails
// (before anything is written).
const kvGet = env.KV.get.bind(env.KV);
env.KV.get = (async (key: string, ...rest: unknown[]) => {
if (key === "token:111980217") {
await env.KV.put("accepted:bot:telegram:tg-token:1001", "other-run");
throw new Error("KV down");
}
return (kvGet as (...a: unknown[]) => Promise<unknown>)(key, ...rest);
}) as KVNamespace["get"];
globalThis.fetch = (async () => {
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), {
status: 200,
});
}) as typeof fetch;
await expect(
handleTelegramUpdate(env, {
update_id: 1001,
message: {
...reply("-100123"),
text: "/gh comment hello",
reply_to_message: {
...reply("-100123"),
text: "acme/widget#7: Add feature",
entities: [{ type: "text_link", url: "https://github.com/acme/widget/issues/7" }],
},
},
}),
).rejects.toThrow();
expect(await env.KV.get("accepted:bot:telegram:tg-token:1001")).toBe("other-run");
});
});
describe("telegram-commands logout and bot identity", () => {
it("never unlinks twice when the logout reply failed", async () => {
const env = createEnv();
const { saveTelegramLink, getTelegramLink } = await import("../server/lib/github/store");
await saveTelegramLink(env.DB, "111", "old");
mockFetch(
() => new Response(JSON.stringify({ ok: false, description: "down" }), { status: 502 }),
);
const update = { update_id: 4242, message: { ...reply("-100123"), text: "/gh logout" } };
await expect(handleTelegramUpdate(env, update)).rejects.toThrow();
// Linked again since; the redelivered logout must leave the new link alone.
await saveTelegramLink(env.DB, "111", "new");
mockFetch(
() => new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), { status: 200 }),
);
await handleTelegramUpdate(env, update);
expect(await getTelegramLink(env.DB, "111")).toBe("new");
});
it("tells two bots' updates with the same number apart", async () => {
let sends = 0;
mockFetch(() => {
sends++;
return new Response(JSON.stringify({ ok: true, result: { message_id: 1 } }), { status: 200 });
});
const update = { update_id: 77, message: { ...reply("-100123"), text: "/gh logout" } };
const kv = createMockKV();
const db = createMockDB();
await handleTelegramUpdate({ ...createEnv(), KV: kv, DB: db, TELEGRAM_TOKEN: "1:a" }, update);
await handleTelegramUpdate({ ...createEnv(), KV: kv, DB: db, TELEGRAM_TOKEN: "2:b" }, update);
expect(sends).toBe(2);
});
});
describe("telegram-commands reply failure after the write", () => {
it("keeps the command done when the reply fails after the comment was written", async () => {
const env = createEnv();
const { saveTelegramLink } = await import("../server/lib/github/store");
await saveTelegramLink(env.DB, "111", "111980217");
await env.KV.put(
"token:111980217",
JSON.stringify({
userId: "111980217",
accessToken: "ghu_test",
expiresAt: Date.now() + 3600_000,
}),
);
let comments = 0;
globalThis.fetch = (async (input: RequestInfo | URL, init?: RequestInit) => {
const url = String(input instanceof Request ? input.url : input);
const method = input instanceof Request ? input.method : (init?.method ?? "GET");
if (url.endsWith("/sendMessage")) return new Response("Bad Gateway", { status: 502 });
if (url.includes("/comments") && method === "POST") comments++;
return new Response(
JSON.stringify({
user: { login: "a" },
html_url: "https://github.com/acme/widget/issues/7#issuecomment-9",
}),
{ status: 201 },
);
}) as typeof fetch;
const update = {
update_id: 2024,
message: {
...reply("-100123"),
text: "/gh comment hello",
reply_to_message: {
...reply("-100123"),
text: "acme/widget#7: Add feature",
entities: [{ type: "text_link", url: "https://github.com/acme/widget/issues/7" }],
},
},
};
// The reply fails: Telegram redelivers the update.
await handleTelegramUpdate(env, update).catch(() => undefined);
await handleTelegramUpdate(env, update).catch(() => undefined);
expect(comments).toBe(1);
});
});